netdev - Re: [PATCH V2 net-next 00/11] Add support of HIBMCGE Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93cacc08-158c-413e-9d4d-dafcfcb57dcd@huawei.com>
Date: Wed, 21 Aug 2024 14:53:18 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
	<liuyonglong@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
	<shiyongbang@...wei.com>, <libaihan@...wei.com>, <andrew@...n.ch>,
	<jdamato@...tly.com>, <horms@...nel.org>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 net-next 00/11] Add support of HIBMCGE Ethernet Driver


on 2024/8/21 9:55, Jakub Kicinski wrote:
> On Tue, 20 Aug 2024 22:01:43 +0800 Jijie Shao wrote:
>> This patch set adds the support of Hisilicon BMC Gigabit Ethernet Driver.
>>
>> This patch set includes basic Rx/Tx functionality. It also includes
>> the registration and interrupt codes.
>>
>> This work provides the initial support to the HIBMCGE and
>> would incrementally add features or enhancements.
>
> Does not build
>
>    ERROR: modpost: "phy_attached_info" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "phy_ethtool_set_link_ksettings" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "phy_connect_direct" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "phy_ethtool_get_link_ksettings" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "phy_start" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "phy_remove_link_mode" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "phy_print_status" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "mdiobus_get_phy" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    ERROR: modpost: "__devm_mdiobus_register" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined!
>    WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)Hi

Hi Jakub:

I can build successfully. Can you tell me your build command?
I think the cause of this problem is that the PHYLIB is not selected in Kconfig.
So I will add "select PHYLIB" in v3

Thanks,

Jijie Shao