netdev - RE: [PATCH net v2] igb: cope with large MAX_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR11MB6117E1E95B5B114534B75814828E2@DM4PR11MB6117.namprd11.prod.outlook.com>
Date: Wed, 21 Aug 2024 06:23:59 +0000
From: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>
To: "Vinschen, Corinna" <vinschen@...hat.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"jtluka@...hat.com" <jtluka@...hat.com>, "jhladky@...hat.com"
	<jhladky@...hat.com>, "sd@...asysnail.net" <sd@...asysnail.net>, "Pucha,
 HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
Subject: RE: [PATCH net v2] igb: cope with large MAX_SKB_FRAGS

> 
> Hello:
> 
> This patch was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@...nel.org>:
> 
> On Fri, 16 Aug 2024 17:20:34 +0200 you wrote:
> > From: Paolo Abeni <pabeni@...hat.com>
> >
> > Sabrina reports that the igb driver does not cope well with large
> > MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload
> > corruption on TX.
> >
> > An easy reproducer is to run ssh to connect to the machine.  With
> > MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails.  This has
> > been reported originally in
> > https://bugzilla.redhat.com/show_bug.cgi?id=2265320

Eh, I missed giving my reviewed-by tag. FWIW thanks for this v2!

> >
> > [...]
> 
> Here is the summary with links:
>   - [net,v2] igb: cope with large MAX_SKB_FRAGS
>     https://git.kernel.org/netdev/net/c/8aba27c4a502
> 
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>