netdev - RE: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to configure fixed link state in phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <LV8PR11MB87006B1F64E014A476B9214F9F8E2@LV8PR11MB8700.namprd11.prod.outlook.com>
Date: Wed, 21 Aug 2024 07:48:43 +0000
From: <Raju.Lakkaraju@...rochip.com>
To: <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <linux@...linux.org.uk>,
	<kuba@...nel.org>, <horms@...nel.org>, <hkallweit1@...il.com>,
	<richardcochran@...il.com>, <rdunlap@...radead.org>,
	<Bryan.Whitehead@...rochip.com>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
 configure fixed link state in phylink

Hi Andrew,

Thank you for review the patch.

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, August 19, 2024 9:39 PM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@...rochip.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; linux@...linux.org.uk;
> kuba@...nel.org; horms@...nel.org; hkallweit1@...il.com;
> richardcochran@...il.com; rdunlap@...radead.org; Bryan Whitehead -
> C21958 <Bryan.Whitehead@...rochip.com>; edumazet@...gle.com;
> pabeni@...hat.com; linux-kernel@...r.kernel.org; UNGLinuxDriver
> <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
> configure fixed link state in phylink
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> > +/**
> > + * phylink_set_fixed_link() - set the fixed link
> > + * @pl: a pointer to a &struct phylink returned from phylink_create()
> > + * @state: a pointer to a struct phylink_link_state.
> > + *
> > + * This function is used when the link parameters are known and do
> > +not change,
> > + * making it suitable for certain types of network connections.
> > + *
> > + * Returns zero on success, or negative error code.
> 
> kernel doc requires a : after Returns. The tooling is getting more picky about
> this and pointing out this error. But there is a lot of code which gets this
> wrong, so you probably cut/paste a bad example.
> 

Ok. I will fix.
You are correct. I did copy/paste the string.

>     Andrew
> 
> ---
> pw-bot: cr

Thanks,
Raju