netdev - RE: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to configure fixed link state in phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <LV8PR11MB8700C786F5F1C274C73036CC9F8E2@LV8PR11MB8700.namprd11.prod.outlook.com>
Date: Wed, 21 Aug 2024 07:55:56 +0000
From: <Raju.Lakkaraju@...rochip.com>
To: <horms@...nel.org>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <linux@...linux.org.uk>,
	<kuba@...nel.org>, <andrew@...n.ch>, <hkallweit1@...il.com>,
	<richardcochran@...il.com>, <rdunlap@...radead.org>,
	<Bryan.Whitehead@...rochip.com>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
 configure fixed link state in phylink


Hi Simon,

Thank you for review the patch.

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Monday, August 19, 2024 9:54 PM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@...rochip.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; linux@...linux.org.uk;
> kuba@...nel.org; andrew@...n.ch; hkallweit1@...il.com;
> richardcochran@...il.com; rdunlap@...radead.org; Bryan Whitehead -
> C21958 <Bryan.Whitehead@...rochip.com>; edumazet@...gle.com;
> pabeni@...hat.com; linux-kernel@...r.kernel.org; UNGLinuxDriver
> <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
> configure fixed link state in phylink
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Mon, Aug 19, 2024 at 10:53:35AM +0530, Raju Lakkaraju wrote:
> > From: Russell King <linux@...linux.org.uk>
> >
> > The function allows for the configuration of a fixed link state for a
> > given phylink instance. This addition is particularly useful for
> > network devices that operate with a fixed link configuration, where
> > the link parameters do not change dynamically. By using
> > `phylink_set_fixed_link()`, drivers can easily set up the fixed link state during
> initialization or configuration changes.
> >
> > Signed-off-by: Russell King <linux@...linux.org.uk>
> > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
> > ---
> > Note: This code was developed by Mr.Russell King.
> 
> Hi,
> 
> I am wondering if we need a user of this function in order for this patch to be
> accepted, as is often the practice for new features.

This patch is Mr. Russell King's developed code which I'm submitting to Linux community for review.
just following Russell's request. 
i.e.
https://lore.kernel.org/netdev/ZsCMtARGCOLsbF9h@shell.armlinux.org.uk/

if it is required, I can send both together in a single series. Please confirm 

Hi Russell, Do you any concerns about Mr. Simon comments?

Thanks,
Raju