netdev - Re: [PATCH net v5 1/2] ptp: ocp: adjust sysfs entries to expose tty information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1c821f2-fac9-4b8b-a90f-585f7153810c@kernel.org>
Date: Fri, 23 Aug 2024 08:10:25 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Vadim Fedorenko <vadfed@...a.com>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Jakub Kicinski
 <kuba@...nel.org>, Jonathan Lemon <jonathan.lemon@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net v5 1/2] ptp: ocp: adjust sysfs entries to expose tty
 information

On 22. 08. 24, 17:44, Vadim Fedorenko wrote:
> Starting v6.8 the serial port subsystem changed the hierarchy of devices
> and symlinks are not working anymore. Previous discussion made it clear
> that the idea of symlinks for tty devices was wrong by design [1].
> Implement additional attributes to expose the information. Fixes tag
> points to the commit which introduced the change.
> 
> [1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/
> 
> Fixes: b286f4e87e32 ("serial: core: Move tty and serdev to be children of serial core port device")
> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>

Looks good to me. Except I still think it should be 2 patches:

>> The conversion to the array needs to go to a separate patch, apparently.
> 
> I'm not sure here. I'm trying to fix the regression introduced back in
> 6.8. The conversion to the array itself doesn't solve the issue, it's
> pure net-next material.

It doesn't matter...

> But the simple fix was NACKed previously, that's
> why I had to introduce such a big change. I would like to keep these
> changes all together in one patch. 

No problem, if you plan on stable to pick this up, mark them both for Cc 
stable.

It's much easier to process in brain and review smaller changes, than a 
large single patch. And especially: it is less error-prone.

thanks,
-- 
-- 
js
suse labs