netdev - Re: [PATCH 1/2] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfd89207-5dd5-4b89-bd54-aa490d34c590@kernel.org>
Date: Fri, 23 Aug 2024 08:10:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Marek Vasut <marex@...x.de>
Cc: linux-wireless@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Adham Abozaeid <adham.abozaeid@...rochip.com>,
 Ajay Singh <ajay.kathat@...rochip.com>,
 Alexis Lothoré <alexis.lothore@...tlin.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Conor Dooley
 <conor+dt@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: wireless: wilc1000: Document WILC3000
 compatible string

On 23/08/2024 03:38, Marek Vasut wrote:
> On 8/22/24 10:07 AM, Krzysztof Kozlowski wrote:
> 
> Hi,
> 
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>>> index 2460ccc082371..1bf3496c21e64 100644
>>> --- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>>> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
>>> @@ -16,7 +16,9 @@ description:
>>>   
>>>   properties:
>>>     compatible:
>>> -    const: microchip,wilc1000
>>> +    enum:
>>> +      - microchip,wilc1000
>>> +      - microchip,wilc3000
>>
>> Your driver change suggests device type is fully auto-detectable
> 
> It seems that way, yes.
> 
>> , thus
>> they are compatible.
> 
> I _think_ the hardware is internally somewhat different, the WILC1000 is 
> WiFi-only device and the WILC3000 has some extra Bluetooth part (which 
> is currently not supported).
> 
> Maybe a fallback compatible string would be better here ?

Yes, that's what I meant by compatibility. 3000 followed by 1000.

Best regards,
Krzysztof