netdev - Re: [PATCHv2 net-next] net: ag71xx: add missing reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N-Et8J8QkikD8j9GE05Gfp_utfgyuqiX5Hmh8R-OP5kqQ@mail.gmail.com>
Date: Fri, 23 Aug 2024 22:23:24 -0700
From: Rosen Penev <rosenp@...il.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 net-next] net: ag71xx: add missing reset_control_put

On Fri, Aug 23, 2024 at 9:48 PM Oleksij Rempel <o.rempel@...gutronix.de> wrote:
>
> Hi Rosen,
>
> On Fri, Aug 23, 2024 at 01:04:18PM -0700, Rosen Penev wrote:
> > The original downstream driver used devm instead of of. The latter
> > requires reset_control_put to be called in all return paths.
>
> At the moment of upstreaming this code, the original driver used
> of_reset_control_get_exclusive() and was fixed by f92bbdcc93 ("ath79:
> ag71xx-mdio: get reset control using devm api")
>
> Why not port the original fix?
On further review, this looks safe to do. Will submit tomorrow.
>
> Regards,
> Oleksij
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |