netdev - Re: [PATCH net-next v7 6/6] net: phy: add Applied Micro QT2025 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALNs47tiPK-TWX8w9abdam=WJBGari3prYCiXZtWHdtgmGzHDA@mail.gmail.com>
Date: Sat, 24 Aug 2024 00:32:34 -0500
From: Trevor Gross <tmgross@...ch.edu>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, 
	miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me, aliceryhl@...gle.com
Subject: Re: [PATCH net-next v7 6/6] net: phy: add Applied Micro QT2025 PHY driver

On Fri, Aug 23, 2024 at 9:08 PM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:
>
> This driver supports Applied Micro Circuits Corporation QT2025 PHY,
> based on a driver for Tehuti Networks TN40xx chips.
> [...]
> +APPLIED MICRO QT2025 PHY DRIVER
> +M:     FUJITA Tomonori <fujita.tomonori@...il.com>
> +R:     Trevor Gross <tmgross@...ch.edu>

Ack (discussed offline)

> +L:     netdev@...r.kernel.org
> +L:     rust-for-linux@...r.kernel.org
> +S:     Maintained
> +F:     drivers/net/phy/qt2025.rs

> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
> new file mode 100644
> index 000000000000..28d8981f410b
> --- /dev/null
> +++ b/drivers/net/phy/qt2025.rs
> @@ -0,0 +1,103 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (C) Tehuti Networks Ltd.
> +// Copyright (C) 2024 FUJITA Tomonori <fujita.tomonori@...il.com>
> +
> +//! Applied Micro Circuits Corporation QT2025 PHY driver
> +//!
> +//! This driver is based on the vendor driver `QT2025_phy.c`. This source
> +//! and firmware can be downloaded on the EN-9320SFP+ support site.
> +//!
> +//! The QT2025 PHY integrates an Intel 8051 micro-controller.

I think the current state of this driver looks pretty good. Thanks for
working on this Tomo.

Reviewed-by: Trevor Gross <tmgross@...ch.edu>