netdev - Re: [PATCH net-next v7 4/6] rust: net::phy unified read/write API for C22 and C45 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALNs47uSeGR_Z_Bor4yKbd848XdohHMam47zwBct39nEmKFb7g@mail.gmail.com>
Date: Sat, 24 Aug 2024 00:44:50 -0500
From: Trevor Gross <tmgross@...ch.edu>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, 
	miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me, aliceryhl@...gle.com
Subject: Re: [PATCH net-next v7 4/6] rust: net::phy unified read/write API for
 C22 and C45 registers

On Fri, Aug 23, 2024 at 9:08 PM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:

> +/// A single MDIO clause 22 register address (5 bits).
> +#[derive(Copy, Clone)]
> +pub struct C22(u8);
>
> [...]
> +/// A single MDIO clause 45 register device and address.
> +#[derive(Copy, Clone)]
> +pub struct Mmd(u8);
>
> [...]
> +pub struct C45 {
> +    devad: Mmd,
> +    regnum: u16,
> +}

Small suggestion: I think these could all be `#[derive(Clone, Copy,
Debug)]` so they are easy to `pr_info!(...)`. C45 doesn't have any
derives.

This could probably be done when it is picked up if there isn't another version.

- Trevor