netdev - Re: [PATCH net-next 00/13] net: header and core spelling corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d15e45f17dcb9c98664590711ac874302a7e6689.camel@posteo.de>
Date: Sun, 25 Aug 2024 07:52:45 +0000
From: Philipp Stanner <stanner@...teo.de>
To: Simon Horman <horms@...nel.org>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, "David S. Miller" <davem@...emloft.net>,
  Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,  Alexandra Winter <wintera@...ux.ibm.com>,
 Thorsten Winkler <twinkler@...ux.ibm.com>, David Ahern
 <dsahern@...nel.org>,  Jay Vosburgh <jv@...sburgh.net>, Andy Gospodarek
 <andy@...yhouse.net>, Subash Abhinov Kasiviswanathan
 <quic_subashab@...cinc.com>, Sean Tranchetti <quic_stranche@...cinc.com>, 
 Paul Moore <paul@...l-moore.com>, Krzysztof Kozlowski <krzk@...nel.org>,
 Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>, Marcelo Ricardo Leitner
 <marcelo.leitner@...il.com>, Xin Long <lucien.xin@...il.com>, Martin
 Schiller <ms@....tdt.de>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org, 
	linux-security-module@...r.kernel.org, linux-sctp@...r.kernel.org, 
	linux-x25@...r.kernel.org
Subject: Re: [PATCH net-next 00/13] net: header and core spelling corrections

Am Donnerstag, dem 22.08.2024 um 13:57 +0100 schrieb Simon Horman:
> This patchset addresses a number of spelling errors in comments in
> Networking files under include/, and files in net/core/. Spelling
> problems are as flagged by codespell.
> 
> It aims to provide patches that can be accepted directly into net-
> next.
> And splits patches up based on maintainer boundaries: many things
> feed directly into net-next. This is a complex process and I
> apologise
> for any errors.

Are you aware that this lessens git blame's ability to provide the
latest relevant change and associated commit message?

Many software projects suffer from whitespace and spelling fixes
preventing git blame from figuring out years later what original code
was intended to do.

I'd consider that improving spelling might not win that cost-benefit-
ratio.


Regards,
P.


> 
> I also plan to address, via separate patches, spelling errors in
> other
> files in the same directories, for files whose changes typically go
> through trees other than net-next (which feed into net-next).
> 
> ---
> Simon Horman (13):
>       packet: Correct spelling in if_packet.h
>       s390/iucv: Correct spelling in iucv.h
>       ip_tunnel: Correct spelling in ip_tunnels.h
>       ipv6: Correct spelling in ipv6.h
>       bonding: Correct spelling in headers
>       net: qualcomm: rmnet: Correct spelling in if_rmnet.h
>       netlabel: Correct spelling in netlabel.h
>       NFC: Correct spelling in headers
>       net: sched: Correct spelling in headers
>       sctp: Correct spelling in headers
>       x25: Correct spelling in x25.h
>       net: Correct spelling in headers
>       net: Correct spelling in net/core
> 
>  include/linux/etherdevice.h    |  2 +-
>  include/linux/if_rmnet.h       |  2 +-
>  include/linux/netdevice.h      |  8 ++++----
>  include/net/addrconf.h         |  2 +-
>  include/net/bond_3ad.h         |  5 ++++-
>  include/net/bond_alb.h         |  2 +-
>  include/net/busy_poll.h        |  2 +-
>  include/net/caif/caif_layer.h  |  4 ++--
>  include/net/caif/cfpkt.h       |  2 +-
>  include/net/dropreason-core.h  |  6 +++---
>  include/net/dst.h              |  2 +-
>  include/net/dst_cache.h        |  2 +-
>  include/net/erspan.h           |  4 ++--
>  include/net/hwbm.h             |  4 ++--
>  include/net/ip_tunnels.h       |  2 +-
>  include/net/ipv6.h             |  4 ++--
>  include/net/iucv/iucv.h        |  2 +-
>  include/net/llc_pdu.h          |  2 +-
>  include/net/netlabel.h         |  2 +-
>  include/net/netlink.h          | 16 ++++++++--------
>  include/net/netns/sctp.h       |  4 ++--
>  include/net/nfc/nci.h          |  2 +-
>  include/net/nfc/nfc.h          |  8 ++++----
>  include/net/pkt_cls.h          |  2 +-
>  include/net/red.h              |  8 ++++----
>  include/net/regulatory.h       |  2 +-
>  include/net/sctp/sctp.h        |  2 +-
>  include/net/sctp/structs.h     | 20 ++++++++++----------
>  include/net/sock.h             |  4 ++--
>  include/net/udp.h              |  2 +-
>  include/net/x25.h              |  2 +-
>  include/uapi/linux/if_packet.h |  7 ++++---
>  include/uapi/linux/in.h        |  2 +-
>  include/uapi/linux/inet_diag.h |  2 +-
>  net/core/dev.c                 |  6 +++---
>  net/core/dev_addr_lists.c      |  6 +++---
>  net/core/fib_rules.c           |  2 +-
>  net/core/gro.c                 |  2 +-
>  net/core/netpoll.c             |  2 +-
>  net/core/pktgen.c              | 10 +++++-----
>  net/core/skbuff.c              |  4 ++--
>  net/core/sock.c                |  6 +++---
>  net/core/utils.c               |  2 +-
>  43 files changed, 93 insertions(+), 89 deletions(-)
> 
> base-commit: 001b98c9897352e914c71d8ffbfa9b79a6e12c3c
> 
>