netdev - Re: [PATCH net-next 00/13] net: header and core spelling corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76d5406b-7c3a-4c8d-8ce7-ac0902fbe206@kernel.org>
Date: Sun, 25 Aug 2024 10:06:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Philipp Stanner <stanner@...teo.de>, Simon Horman <horms@...nel.org>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Alexandra Winter <wintera@...ux.ibm.com>,
 Thorsten Winkler <twinkler@...ux.ibm.com>, David Ahern <dsahern@...nel.org>,
 Jay Vosburgh <jv@...sburgh.net>, Andy Gospodarek <andy@...yhouse.net>,
 Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>,
 Sean Tranchetti <quic_stranche@...cinc.com>, Paul Moore
 <paul@...l-moore.com>, Jamal Hadi Salim <jhs@...atatu.com>,
 Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
 Xin Long <lucien.xin@...il.com>, Martin Schiller <ms@....tdt.de>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
 linux-security-module@...r.kernel.org, linux-sctp@...r.kernel.org,
 linux-x25@...r.kernel.org
Subject: Re: [PATCH net-next 00/13] net: header and core spelling corrections

On 25/08/2024 09:52, Philipp Stanner wrote:
> Am Donnerstag, dem 22.08.2024 um 13:57 +0100 schrieb Simon Horman:
>> This patchset addresses a number of spelling errors in comments in
>> Networking files under include/, and files in net/core/. Spelling
>> problems are as flagged by codespell.
>>
>> It aims to provide patches that can be accepted directly into net-
>> next.
>> And splits patches up based on maintainer boundaries: many things
>> feed directly into net-next. This is a complex process and I
>> apologise
>> for any errors.
> 
> Are you aware that this lessens git blame's ability to provide the
> latest relevant change and associated commit message?

Considering how many code style changes the kernel receives, I already
(and not only me) moved away to just `git log --follow`, so I don't find
one more step for `git blame` a problem.

> 
> Many software projects suffer from whitespace and spelling fixes
> preventing git blame from figuring out years later what original code
> was intended to do.
> 
> I'd consider that improving spelling might not win that cost-benefit-
> ratio.

I would rather claim that impact on backporting is more important, yet
still fixing style makes code more readable thus maintainable. And
that's a benefit.

Best regards,
Krzysztof