netdev - Re: [Patch net-next] net/handshake: use sockfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZszNJBRScwD6pXPB@tissot.1015granger.net>
Date: Mon, 26 Aug 2024 14:44:52 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: A K M Fazla Mehrab <a.mehrab@...edance.com>
Cc: netdev@...r.kernel.org, kernel-tls-handshake@...ts.linux.dev
Subject: Re: [Patch net-next] net/handshake: use sockfd_put() helper

Hi-

On Mon, Aug 26, 2024 at 06:26:52PM +0000, A K M Fazla Mehrab wrote:
> Replace fput() with sockfd_put() in handshake_nl_done_doit().

The patch description needs to explain why. Lacking any other
context, I assume this is a clean-up for consistency with other
sockfd_lookup() call sites and that no behavior change is expected.

Reviewed-by: Chuck Lever <chuck.lever@...cle.com>


> Signed-off-by: A K M Fazla Mehrab <a.mehrab@...edance.com>
> ---
>  net/handshake/netlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c
> index 89637e732866..7e46d130dce2 100644
> --- a/net/handshake/netlink.c
> +++ b/net/handshake/netlink.c
> @@ -153,7 +153,7 @@ int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info)
>  	if (!req) {
>  		err = -EBUSY;
>  		trace_handshake_cmd_done_err(net, req, sock->sk, err);
> -		fput(sock->file);
> +		sockfd_put(sock);
>  		return err;
>  	}
>  
> @@ -164,7 +164,7 @@ int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info)
>  		status = nla_get_u32(info->attrs[HANDSHAKE_A_DONE_STATUS]);
>  
>  	handshake_complete(req, status, info);
> -	fput(sock->file);
> +	sockfd_put(sock);
>  	return 0;
>  }
>  
> -- 
> 2.20.1
> 

-- 
Chuck Lever