netdev - Re: [External] Re: [Patch net-next] net/handshake: use sockfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKDkqhpxQpMjsSBLb5hdbrN_uZJLAxf17A_JAhcnscTfEsfew@mail.gmail.com>
Date: Mon, 26 Aug 2024 15:24:42 -0700
From: "A K M Fazla Mehrab ." <a.mehrab@...edance.com>
To: Chuck Lever <chuck.lever@...cle.com>
Cc: netdev@...r.kernel.org, kernel-tls-handshake@...ts.linux.dev
Subject: Re: [External] Re: [Patch net-next] net/handshake: use sockfd_put() helper

Hi,

On Mon, Aug 26, 2024 at 11:45 AM Chuck Lever <chuck.lever@...cle.com> wrote:
>
> Hi-
>
> On Mon, Aug 26, 2024 at 06:26:52PM +0000, A K M Fazla Mehrab wrote:
> > Replace fput() with sockfd_put() in handshake_nl_done_doit().
>
> The patch description needs to explain why. Lacking any other
> context, I assume this is a clean-up for consistency with other
> sockfd_lookup() call sites and that no behavior change is expected.

Yeah, this is indeed a clean-up and no behavior change is expected. I
will be careful to add more context in future patches.

Thanks!