netdev - Re: [PATCH 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9567ddd-cc84-4fbc-bb6d-b719b2cb723c@redhat.com>
Date: Mon, 26 Aug 2024 18:25:49 -0400
From: Jon Maloy <jmaloy@...hat.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 davem@...emloft.net, kuba@...nel.org, passt-dev@...st.top,
 sbrivio@...hat.com, lvivier@...hat.com, dgibson@...hat.com,
 eric.dumazet@...il.com, edumazet@...gle.com
Subject: Re: [PATCH 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6



On 2024-08-23 19:51, Jason Xing wrote:
> On Sat, Aug 24, 2024 at 5:19 AM <jmaloy@...hat.com> wrote:
>> From: Jon Maloy <jmaloy@...hat.com>
>>
>> When we added the SO_PEEK_OFF socket option to TCP we forgot
>> to add it even for TCP on IPv6.
> Even though you said "we forgot", I'm not sure if this patch series
> belongs to net-next material...
I agree regarding the fix.
The selftest is new however, and belongs in net-next because of that.
Since I made it one series I decided for net-next, but I leave it to the 
discretion of Jakub and the maintainer of the linux-kselftest system to 
decide where they go.

///jon

>
>> We do that here.
>>
>> Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
>> Reviewed-by: David Gibson <david@...son.dropbear.id.au>
>> Reviewed-by: Stefano Brivio <sbrivio@...hat.com>
>> Tested-by: Stefano Brivio <sbrivio@...hat.com>
>> Signed-off-by: Jon Maloy <jmaloy@...hat.com>
> Reviewed-by: Jason Xing <kerneljasonxing@...il.com>
>
> You seem to forget to carry Eric's Reviewed-by tag, please see the link :)
> https://lore.kernel.org/all/CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=8OQ@mail.gmail.com/
>
> Thanks,
> Jason
>