netdev - Re: [PATCH 2/2] selftests: add selftest for tcp SO_PEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoC-CTaD-_68Nee+CoysJV7zYojqqgU8Y+Nq6RkQRuv=DA@mail.gmail.com>
Date: Sun, 1 Sep 2024 08:32:57 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jon Maloy <jmaloy@...hat.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	davem@...emloft.net, kuba@...nel.org, passt-dev@...st.top, sbrivio@...hat.com, 
	lvivier@...hat.com, dgibson@...hat.com, eric.dumazet@...il.com, 
	edumazet@...gle.com
Subject: Re: [PATCH 2/2] selftests: add selftest for tcp SO_PEEK_OFF support

Hello Jon,

On Tue, Aug 27, 2024 at 3:58 AM Jon Maloy <jmaloy@...hat.com> wrote:
>
>
>
> On 2024-08-23 19:44, Jason Xing wrote:
> > Hello Jon,
> >
> > On Sat, Aug 24, 2024 at 5:19 AM <jmaloy@...hat.com> wrote:
> >> From: Jon Maloy <jmaloy@...hat.com>
> >>
> >> We add a selftest to check that the new feature added in
> >> commit 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
> >> works correctly.
> >>
> >> Reviewed-by: Stefano Brivio <sbrivio@...hat.com>
> >> Tested-by: Stefano Brivio <sbrivio@...hat.com>
> >> Signed-off-by: Jon Maloy <jmaloy@...hat.com>
> > Thanks for working on this. Sorry that I just noticed I missed your
> > previous reply :(
> There is still the ditto UDP selftest to be done ;-)

The reason why I didn't respond at that time is because I was unsure
if I had enough time to finish it. Now it's time.

After digging into this, there will be a lot of duplicated code if I
write a new one named like "udp_so_peek_off". I think adjusting your
tcp_so_peek_off.c to complete the UDP part is just fine. Of course,
tcp_so_peek_off.c will be renamed :)

I will post one later to see if it's reasonable...

Thanks,
Jason