lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240826132324.14572112@kernel.org>
Date: Mon, 26 Aug 2024 13:23:24 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Shahed Shaikh <shshaikh@...vell.com>, Manish Chopra
 <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] qlcnic: make read-only const array key static

On Thu, 22 Aug 2024 22:10:28 +0100 Colin Ian King wrote:
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> index bcef8ab715bf..5a91e9f9c408 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> @@ -2045,9 +2045,11 @@ int qlcnic_83xx_config_rss(struct qlcnic_adapter *adapter, int enable)
>  	int err;
>  	u32 word;
>  	struct qlcnic_cmd_args cmd;
> -	const u64 key[] = { 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
> -			    0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
> -			    0x255b0ec26d5a56daULL };
> +	static const u64 key[] = {
> +		0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
> +		0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
> +		0x255b0ec26d5a56daULL
> +	};

Move it up, please, reverse xmas tree
-- 
pw-bot: cr

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ