netdev - Re: [PATCH net-next v2] et131x: Remove NULL check of list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240826132726.25570e37@kernel.org>
Date: Mon, 26 Aug 2024 13:27:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yuesong Li <liyuesong@...o.com>
Cc: mark.einon@...il.com, davem@...emloft.net, dumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH net-next v2] et131x: Remove NULL check of list_entry()

On Fri, 23 Aug 2024 09:27:37 +0800 Yuesong Li wrote:
> list_entry() will never return a NULL pointer, thus remove the
> check.

Unclear to me whether the intent of this code is to check for empty
list or this is defensive programming. Let's leave it be.
-- 
pw-bot: reject