netdev - Re: lib/packing.c behaving weird if buffer length is not multiple of 4 with QUIRK_LSW32_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f03563b-2cca-4517-855c-1516914c78ef@intel.com>
Date: Mon, 26 Aug 2024 15:03:33 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Vladimir Oltean <olteanv@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: lib/packing.c behaving weird if buffer length is not multiple of
 4 with QUIRK_LSW32_IS_FIRST



On 8/23/2024 12:53 PM, Jacob Keller wrote:
> I so far think the likely issue is with the way we handle the box and
> mask offsets. Somehow we must be shifting things in a strange way that
> causes us to discard bits, but only when we deal with the
> QUIRK_MSB_ON_THE_RIGHT.
> 
> Thanks,
> Jake

I eventually figured out what i believe is wrong here, and have a fix.
I'm going to include it in the series I send for using <linux/packing.h>
in the ice driver, along with the additional KUnit tests.

Thanks,
Jake