netdev - Re: [net-next v2 6/9] net: ethernet: broadcom: bcm63xx_enet: Convert to devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240826151518.6ccaec1f@kernel.org>
Date: Mon, 26 Aug 2024 15:15:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yangtao Li <frank.li@...o.com>
Cc: clement.leger@...tlin.com, andrew@...n.ch, f.fainelli@...il.com,
 olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, ulli.kroll@...glemail.com, linus.walleij@...aro.org,
 marcin.s.wojtas@...il.com, linux@...linux.org.uk,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com,
 mcoquelin.stm32@...il.com, hkallweit1@...il.com, kees@...nel.org,
 justinstitt@...gle.com, u.kleine-koenig@...gutronix.de, horms@...nel.org,
 sd@...asysnail.net, linux-renesas-soc@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com
Subject: Re: [net-next v2 6/9] net: ethernet: broadcom: bcm63xx_enet:
 Convert to devm_clk_get_enabled()

On Fri, 23 Aug 2024 01:21:18 -0600 Yangtao Li wrote:
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 3c0e3b9828be..6e288cee2c35 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -1718,6 +1718,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
>  	struct bcm63xx_enet_platform_data *pd;

move the local clock variables here, keep lines longest to shortest

>  	int irq, irq_rx, irq_tx;
>  	struct mii_bus *bus;
> +	struct clk *phy_clk, *mac_clk;