netdev - Re: [PATCH net-next 3/5] net/netfilter: make use of the helper macro LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zs37l04h3bsK8LIE@calendula>
Date: Tue, 27 Aug 2024 18:15:19 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, jmaloy@...hat.com,
	ying.xue@...driver.com, kadlec@...filter.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH net-next 3/5] net/netfilter: make use of the helper macro
 LIST_HEAD()

Hi,

On Tue, Aug 27, 2024 at 06:04:05PM +0800, Hongbo Li wrote:
> list_head can be initialized automatically with LIST_HEAD()
> instead of calling INIT_LIST_HEAD(). Here we can simplify
> the code.
> 
> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
> ---
>  net/netfilter/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/netfilter/core.c b/net/netfilter/core.c
> index b00fc285b334..93642fcd379c 100644
> --- a/net/netfilter/core.c
> +++ b/net/netfilter/core.c
> @@ -655,10 +655,8 @@ void nf_hook_slow_list(struct list_head *head, struct nf_hook_state *state,
>  		       const struct nf_hook_entries *e)
>  {
>  	struct sk_buff *skb, *next;
> -	struct list_head sublist;
>  	int ret;
> -
> -	INIT_LIST_HEAD(&sublist);
> +	LIST_HEAD(sublist);

comestic:

  	struct sk_buff *skb, *next;
	LIST_HEAD(sublist);          <- here
  	int ret;

I think this should be included in the variable declaration area at
the beginning of this function.

>  	list_for_each_entry_safe(skb, next, head, list) {
>  		skb_list_del_init(skb);
> -- 
> 2.34.1
> 
>