| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202408280039.0XTdLUnn-lkp@intel.com>
Date: Wed, 28 Aug 2024 00:23:42 +0800
From: kernel test robot <lkp@...el.com>
To: Hongbo Li <lihongbo22@...wei.com>, sam@...dozajonas.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, horms@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, lihongbo22@...wei.com,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net/ncsi: Use str_up_down to simplify
the code
Hi Hongbo,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Hongbo-Li/net-ncsi-Use-str_up_down-to-simplify-the-code/20240827-104622
base: net-next/main
patch link: https://lore.kernel.org/r/20240827025246.963115-2-lihongbo22%40huawei.com
patch subject: [PATCH net-next v2 1/2] net/ncsi: Use str_up_down to simplify the code
config: arc-randconfig-001-20240827 (https://download.01.org/0day-ci/archive/20240828/202408280039.0XTdLUnn-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240828/202408280039.0XTdLUnn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408280039.0XTdLUnn-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from include/linux/skbuff.h:38,
from include/net/net_namespace.h:43,
from include/linux/netdevice.h:38,
from net/ncsi/ncsi-manage.c:9:
net/ncsi/ncsi-manage.c: In function 'ncsi_choose_active_channel':
>> net/ncsi/ncsi-manage.c:1284:44: error: implicit declaration of function 'str_up_down' [-Werror=implicit-function-declaration]
1284 | str_up_down(ncm->data[2] & 0x1));
| ^~~~~~~~~~~
include/net/net_debug.h:66:60: note: in definition of macro 'netdev_dbg'
66 | netdev_printk(KERN_DEBUG, __dev, format, ##args); \
| ^~~~
>> net/ncsi/ncsi-manage.c:1282:44: warning: format '%s' expects argument of type 'char *', but argument 5 has type 'int' [-Wformat=]
1282 | "NCSI: Channel %u added to queue (link %s)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1283 | nc->id,
1284 | str_up_down(ncm->data[2] & 0x1));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
include/net/net_debug.h:66:50: note: in definition of macro 'netdev_dbg'
66 | netdev_printk(KERN_DEBUG, __dev, format, ##args); \
| ^~~~~~
net/ncsi/ncsi-manage.c:1282:84: note: format string is defined here
1282 | "NCSI: Channel %u added to queue (link %s)\n",
| ~^
| |
| char *
| %d
cc1: some warnings being treated as errors
vim +/str_up_down +1284 net/ncsi/ncsi-manage.c
1224
1225 static int ncsi_choose_active_channel(struct ncsi_dev_priv *ndp)
1226 {
1227 struct ncsi_channel *nc, *found, *hot_nc;
1228 struct ncsi_channel_mode *ncm;
1229 unsigned long flags, cflags;
1230 struct ncsi_package *np;
1231 bool with_link;
1232
1233 spin_lock_irqsave(&ndp->lock, flags);
1234 hot_nc = ndp->hot_channel;
1235 spin_unlock_irqrestore(&ndp->lock, flags);
1236
1237 /* By default the search is done once an inactive channel with up
1238 * link is found, unless a preferred channel is set.
1239 * If multi_package or multi_channel are configured all channels in the
1240 * whitelist are added to the channel queue.
1241 */
1242 found = NULL;
1243 with_link = false;
1244 NCSI_FOR_EACH_PACKAGE(ndp, np) {
1245 if (!(ndp->package_whitelist & (0x1 << np->id)))
1246 continue;
1247 NCSI_FOR_EACH_CHANNEL(np, nc) {
1248 if (!(np->channel_whitelist & (0x1 << nc->id)))
1249 continue;
1250
1251 spin_lock_irqsave(&nc->lock, cflags);
1252
1253 if (!list_empty(&nc->link) ||
1254 nc->state != NCSI_CHANNEL_INACTIVE) {
1255 spin_unlock_irqrestore(&nc->lock, cflags);
1256 continue;
1257 }
1258
1259 if (!found)
1260 found = nc;
1261
1262 if (nc == hot_nc)
1263 found = nc;
1264
1265 ncm = &nc->modes[NCSI_MODE_LINK];
1266 if (ncm->data[2] & 0x1) {
1267 found = nc;
1268 with_link = true;
1269 }
1270
1271 /* If multi_channel is enabled configure all valid
1272 * channels whether or not they currently have link
1273 * so they will have AENs enabled.
1274 */
1275 if (with_link || np->multi_channel) {
1276 spin_lock_irqsave(&ndp->lock, flags);
1277 list_add_tail_rcu(&nc->link,
1278 &ndp->channel_queue);
1279 spin_unlock_irqrestore(&ndp->lock, flags);
1280
1281 netdev_dbg(ndp->ndev.dev,
> 1282 "NCSI: Channel %u added to queue (link %s)\n",
1283 nc->id,
> 1284 str_up_down(ncm->data[2] & 0x1));
1285 }
1286
1287 spin_unlock_irqrestore(&nc->lock, cflags);
1288
1289 if (with_link && !np->multi_channel)
1290 break;
1291 }
1292 if (with_link && !ndp->multi_package)
1293 break;
1294 }
1295
1296 if (list_empty(&ndp->channel_queue) && found) {
1297 netdev_info(ndp->ndev.dev,
1298 "NCSI: No channel with link found, configuring channel %u\n",
1299 found->id);
1300 spin_lock_irqsave(&ndp->lock, flags);
1301 list_add_tail_rcu(&found->link, &ndp->channel_queue);
1302 spin_unlock_irqrestore(&ndp->lock, flags);
1303 } else if (!found) {
1304 netdev_warn(ndp->ndev.dev,
1305 "NCSI: No channel found to configure!\n");
1306 ncsi_report_link(ndp, true);
1307 return -ENODEV;
1308 }
1309
1310 return ncsi_process_next_channel(ndp);
1311 }
1312
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists