netdev - Re: [PATCH net-next v2 2/2] eth: fbnic: Add support to fetch group stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1a467cd-40f6-42d5-aef3-6b7a288ba728@gmail.com>
Date: Wed, 28 Aug 2024 10:50:21 -0700
From: Mohsin Bashir <mohsin.bashr@...il.com>
To: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org
Cc: alexanderduyck@...com, kuba@...nel.org, andrew@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 kernel-team@...a.com, sanmanpradhan@...a.com, sdf@...ichev.me,
 jdamato@...tly.com
Subject: Re: [PATCH net-next v2 2/2] eth: fbnic: Add support to fetch group
 stats


On 8/28/24 7:37 AM, Simon Horman wrote:
> On Tue, Aug 27, 2024 at 01:59:04PM -0700, Mohsin Bashir wrote:
>> Add support for group stats for mac. The fbnic_set_counter helps prevent
>> overriding the default values for counters which are not collected by the device.
>>
>> The 'reset' flag in 'get_eth_mac_stats' allows choosing between
>> resetting the counter to recent most value or fecthing the aggregate
> nit: fetching
Thank you for pointing.
>
>> values of counters. This is important to cater for cases such as
>> device reset.
>>
>> The 'fbnic_stat_rd64' read 64b stats counters in a consistent fashion using
>> high-low-high approach. This allows to isolate cases where counter is
>> wrapped between the reads.
>>
>> Command: ethtool -S eth0 --groups eth-mac
>> Example Output:
>> eth-mac-FramesTransmittedOK: 421644
>> eth-mac-FramesReceivedOK: 3849708
>> eth-mac-FrameCheckSequenceErrors: 0
>> eth-mac-AlignmentErrors: 0
>> eth-mac-OctetsTransmittedOK: 64799060
>> eth-mac-FramesLostDueToIntMACXmitError: 0
>> eth-mac-OctetsReceivedOK: 5134513531
>> eth-mac-FramesLostDueToIntMACRcvError: 0
>> eth-mac-MulticastFramesXmittedOK: 568
>> eth-mac-BroadcastFramesXmittedOK: 454
>> eth-mac-MulticastFramesReceivedOK: 276106
>> eth-mac-BroadcastFramesReceivedOK: 26119
>> eth-mac-FrameTooLongErrors: 0
>>
>> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> ...