netdev - Re: [PATCH net-next v2 1/2] eth: fbnic: Add ethtool support for fbnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828111816.5749db28@kernel.org>
Date: Wed, 28 Aug 2024 11:18:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: Mohsin Bashir <mohsin.bashr@...il.com>, netdev@...r.kernel.org,
 alexanderduyck@...com, andrew@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, kernel-team@...a.com,
 sanmanpradhan@...a.com, sdf@...ichev.me, jdamato@...tly.com
Subject: Re: [PATCH net-next v2 1/2] eth: fbnic: Add ethtool support for
 fbnic

On Wed, 28 Aug 2024 10:49:06 -0700 Mohsin Bashir wrote:
> > Isn't it cleaner to have it in sth like fbnic_ethtool.h file? Probably
> > you will have more functions there in the future.
>
> It would definitely be cleaner if have a large number of functions which 
> isn't the case hence, did not add fbnic_ethtool.h

To further clarify, if I'm grepping right - the more fully featured
"prototype" driver out of tree only exposes this one function from 
fbnic_ethtool.c

Most ethtool functions get hooked in via ops, and ethtool code calls
out, rather than getting called by the driver itself. So it's probably
fine (and I only mean in this particular case, IDK if all the headers
in fbnic are well organized, it's been a while.)