netdev - Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829094910.28ccd6ca@device-28.home>
Date: Thu, 29 Aug 2024 09:49:10 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>,
 <linux@...linux.org.uk>, <kuba@...nel.org>, <andrew@...n.ch>,
 <hkallweit1@...il.com>, <richardcochran@...il.com>,
 <rdunlap@...radead.org>, <Bryan.Whitehead@...rochip.com>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
 <horms@...nel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink

Hello Raju,

On Thu, 29 Aug 2024 11:21:31 +0530
Raju Lakkaraju <Raju.Lakkaraju@...rochip.com> wrote:

> Migrate phy support from phylib to phylink.
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>

[...]

> +static void lan743x_phylink_disconnect(struct lan743x_adapter *adapter)
> +{
> +	struct net_device *netdev = adapter->netdev;
> +	struct phy_device *phydev = netdev->phydev;
> +
> +	phylink_stop(adapter->phylink);
> +	phylink_disconnect_phy(adapter->phylink);
> +
> +	if (phydev)
> +		if (phy_is_pseudo_fixed_link(phydev))
> +			fixed_phy_unregister(phydev);

You shouldn't manually deal with the fixed_phy when using phylink, it
handles fixed links already for you, without a PHY.

Thanks,

Maxime