netdev - Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtFaYQRQXi/8Q+qx@HYD-DK-UNGSW21.microchip.com>
Date: Fri, 30 Aug 2024 11:06:33 +0530
From: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
CC: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <linux@...linux.org.uk>, <kuba@...nel.org>,
	<andrew@...n.ch>, <hkallweit1@...il.com>, <richardcochran@...il.com>,
	<rdunlap@...radead.org>, <Bryan.Whitehead@...rochip.com>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
	<horms@...nel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink

Hello Maxime,

Thank you for review the patches.

The 08/29/2024 09:49, Maxime Chevallier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello Raju,
> 
> On Thu, 29 Aug 2024 11:21:31 +0530
> Raju Lakkaraju <Raju.Lakkaraju@...rochip.com> wrote:
> 
> > Migrate phy support from phylib to phylink.
> >
> > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
> 
> [...]
> 
> > +static void lan743x_phylink_disconnect(struct lan743x_adapter *adapter)
> > +{
> > +     struct net_device *netdev = adapter->netdev;
> > +     struct phy_device *phydev = netdev->phydev;
> > +
> > +     phylink_stop(adapter->phylink);
> > +     phylink_disconnect_phy(adapter->phylink);
> > +
> > +     if (phydev)
> > +             if (phy_is_pseudo_fixed_link(phydev))
> > +                     fixed_phy_unregister(phydev);
> 
> You shouldn't manually deal with the fixed_phy when using phylink, it
> handles fixed links already for you, without a PHY.

Sure.
I wll remove this fixed_phy unregister here.

> 
> Thanks,
> 
> Maxime

-- 
Thanks,                                                                         
Raju