netdev - Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device writeable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829074832.0f091f53@kernel.org>
Date: Thu, 29 Aug 2024 07:48:32 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Bharat Bhushan <bharatb.linux@...il.com>
Cc: Bharat Bhushan <bbhushan2@...vell.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, sgoutham@...vell.com, gakula@...vell.com,
 sbhatta@...vell.com, hkelam@...vell.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, jerinj@...vell.com,
 lcherian@...vell.com, richardcochran@...il.com
Subject: Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device
 writeable

On Thu, 29 Aug 2024 11:17:25 +0530 Bharat Bhushan wrote:
> > How did you test this prior to adding skb_unshare()?
> > Could you share some performance data with this change?  
> 
> testing using flood ping and iperf with multiple instance,

Makes sense, neither of these will detect corruption of data pages :(
IIRC iperf just ignores the data, ping doesn't retransmit.
You gotta beef up your testing...

> I do not see any drop in performance numbers

Well. What's the difference in CPU busy time of v5 vs v7?
You'll copy all TCP packets, they are (pretty much) all clones.