[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240829080922.254736cd@kernel.org>
Date: Thu, 29 Aug 2024 08:09:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alejandro Lucero Palau <alucerop@....com>
Cc: Jacob Keller <jacob.e.keller@...el.com>, Edward Cree
<ecree.xilinx@...il.com>, Shen Lichuan <shenlichuan@...o.com>,
habetsm.xilinx@...il.com, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, netdev@...r.kernel.org, linux-net-drivers@....com,
linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] sfc: Convert to use ERR_CAST()
On Thu, 29 Aug 2024 07:47:34 +0100 Alejandro Lucero Palau wrote:
> On 8/29/24 00:01, Jakub Kicinski wrote:
> > On Wed, 28 Aug 2024 15:31:08 -0700 Jacob Keller wrote:
> >> Somewhat unrelated but you could cleanup some of the confusion by using
> >> __free(kfree) annotation from <linux/cleanup.h> to avoid needing to
> >> manually free ctr in error paths, and just use return_ptr() return the
> >> value at the end.
> > Please don't send people towards __free(). In general, but especially as
> > part of random cleanups.
>
> Could you explain why or point to a discussion about it?
It was discussed multiple times on the list and various community calls,
someone was supposed to document it but didn't. So I guess I should...
Powered by blists - more mailing lists