netdev - Re: [PATCH net,v7] net/smc: prevent NULL pointer dereference in txopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+sy3Sgg8Ux8M1rmdKhBTv=vJfzVB06MS0tk6uztr4Eqg@mail.gmail.com>
Date: Thu, 29 Aug 2024 17:12:27 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jeongjun Park <aha310510@...il.com>
Cc: wenjia@...ux.ibm.com, jaka@...ux.ibm.com, alibuda@...ux.alibaba.com, 
	tonylu@...ux.alibaba.com, guwen@...ux.alibaba.com, davem@...emloft.net, 
	kuba@...nel.org, pabeni@...hat.com, dust.li@...ux.alibaba.com, 
	linux-s390@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, syzkaller <syzkaller@...glegroups.com>
Subject: Re: [PATCH net,v7] net/smc: prevent NULL pointer dereference in txopt_get

On Thu, Aug 29, 2024 at 5:57 AM Jeongjun Park <aha310510@...il.com> wrote:
>
> Since smc_inet6_prot does not initialize ipv6_pinfo_offset, inet6_create()
> copies an incorrect address value, sk + 0 (offset), to inet_sk(sk)->pinet6.
>
> In addition, since inet_sk(sk)->pinet6 and smc_sk(sk)->clcsock practically
> point to the same address, when smc_create_clcsk() stores the newly
> created clcsock in smc_sk(sk)->clcsock, inet_sk(sk)->pinet6 is corrupted
> into clcsock. This causes NULL pointer dereference and various other
> memory corruptions.
>
> To solve this problem, you need to initialize ipv6_pinfo_offset, add a
> smc6_sock structure, and then add ipv6_pinfo as the second member of
> the smc_sock structure.
>
> Reported-by: syzkaller <syzkaller@...glegroups.com>
> Fixes: d25a92ccae6b ("net/smc: Introduce IPPROTO_SMC")
> Signed-off-by: Jeongjun Park <aha310510@...il.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>