netdev - Re: [PATCH net-next v2 2/2] net: make SOF_TIMESTAMPING_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoCXTwarrWpaZ8adVz9cV0FsROTBRHJS5v3YOtE0jJD+ZQ@mail.gmail.com>
Date: Fri, 30 Aug 2024 08:40:47 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	dsahern@...nel.org, willemb@...gle.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>, Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next v2 2/2] net: make SOF_TIMESTAMPING_RX_SOFTWARE
 feature per socket

Hello Jakub,

On Fri, Aug 30, 2024 at 3:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 29 Aug 2024 00:01:45 +0800 Jason Xing wrote:
> > One more important and special thing is that we should take care of
> > errqueue recv path because we rely on errqueue to get our timestamps
> > for sendmsg(). Or else, If the user wants to read when setting
> > SOF_TIMESTAMPING_TX_ACK, something like this, we cannot get timestamps,
> > for example, in TCP case. So we should consider those
> > SOF_TIMESTAMPING_TX_* flags.
>
> I read this 3 times, I don't know what you're trying to say.

Sorry about that. It looks like I really need more time to improve my
written English...

I was trying to say:
In this case, we expect to control whether we can report the rx
timestamp in this function. But we also need to handle the egress
path, or else reporting the tx timestamp will fail. Egress path and
ingress path will finally call sock_recv_timestamp(). We have to
distinguish them. Errqueue is a good indicator to reflect the flow
direction.

Never mind. I'm going to replace the series with a safer alternative
solution, which was suggested by Willem a few hours ago.

Thanks,
Jason