netdev - RE: [PATCH net] RDMA/mana_ib: use the correct page size for mapping user-mode doorbell page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR21MB44566F4DC8EA85CBDC754A14CE972@PH0PR21MB4456.namprd21.prod.outlook.com>
Date: Fri, 30 Aug 2024 00:54:28 +0000
From: Long Li <longli@...rosoft.com>
To: Simon Horman <horms@...nel.org>, "longli@...uxonhyperv.com"
	<longli@...uxonhyperv.com>
CC: Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Ajay
 Sharma <sharmaajay@...rosoft.com>, Konstantin Taranov
	<kotaranov@...rosoft.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH net] RDMA/mana_ib: use the correct page size for mapping
 user-mode doorbell page

> Subject: Re: [PATCH net] RDMA/mana_ib: use the correct page size for
> mapping user-mode doorbell page
> 
> On Wed, Aug 28, 2024 at 01:06:09PM -0700, longli@...uxonhyperv.com
> wrote:
> > From: Long Li <longli@...rosoft.com>
> >
> > When mapping doorbell page from user-mode, the driver should use the
> > system page size as the doorbell is allocated via mmap() from user-mode.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure
> > Network Adapter")
> > Signed-off-by: Long Li <longli@...rosoft.com>
> > ---
> >  drivers/infiniband/hw/mana/main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/mana/main.c
> > b/drivers/infiniband/hw/mana/main.c
> > index f68f54aea820..b26c4ebec2e0 100644
> > --- a/drivers/infiniband/hw/mana/main.c
> > +++ b/drivers/infiniband/hw/mana/main.c
> > @@ -511,13 +511,13 @@ int mana_ib_mmap(struct ib_ucontext
> *ibcontext, struct vm_area_struct *vma)
> >  	      PAGE_SHIFT;
> >  	prot = pgprot_writecombine(vma->vm_page_prot);
> >
> > -	ret = rdma_user_mmap_io(ibcontext, vma, pfn, gc->db_page_size,
> prot,
> > +	ret = rdma_user_mmap_io(ibcontext, vma, pfn, PAGE_SIZE, prot,
> >  				NULL);
> >  	if (ret)
> >  		ibdev_dbg(ibdev, "can't rdma_user_mmap_io ret %d\n", ret);
> >  	else
> >  		ibdev_dbg(ibdev, "mapped I/O pfn 0x%llx page_size %u,
> ret %d\n",
> > -			  pfn, gc->db_page_size, ret);
> > +			  pfn, PAGE_SIZE, ret);
> 
> This is not a full review, but according to both clang-18 and gcc-14, this patch
> should also update the format specifier from %u to %lu.

Thank you. Will send v2 to fix it.

Long