netdev - Re: [PATCH net-next 01/12] net: dsa: bcm_sf2: Convert using devm_clk_get_optional_enabled() in bcm_sf2_sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e92f33b-9900-4834-80e1-dcbb48cd8394@broadcom.com>
Date: Mon, 2 Sep 2024 08:20:35 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Li Zetao <lizetao1@...wei.com>, andrew@...n.ch, olteanv@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, wens@...e.org, jernej.skrabec@...il.com,
 samuel@...lland.org, heiko@...ech.de, yisen.zhuang@...wei.com,
 salil.mehta@...wei.com, hauke@...ke-m.de, alexandre.torgue@...s.st.com,
 joabreu@...opsys.com, mcoquelin.stm32@...il.com, wellslutw@...il.com,
 radhey.shyam.pandey@....com, michal.simek@....com,
 ajay.kathat@...rochip.com, claudiu.beznea@...on.dev, kvalo@...nel.org,
 u.kleine-koenig@...gutronix.de, jacky_chou@...eedtech.com
Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-rockchip@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com, linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next 01/12] net: dsa: bcm_sf2: Convert using
 devm_clk_get_optional_enabled() in bcm_sf2_sw_probe()



On 8/30/2024 7:13 PM, Li Zetao wrote:
> Use devm_clk_get_optional_enabled() instead of devm_clk_get_optional() +
> clk_prepare_enable(), which can make the clk consistent with the device
> life cycle and reduce the risk of unreleased clk resources. Since the
> device framework has automatically released the clk resource, there is
> no need to execute clk_disable_unprepare(clk) on the error path, drop
> the out_clk_mdiv and out_clk labels, and the original error process can
> be returned directly.
> 
> Signed-off-by: Li Zetao <lizetao1@...wei.com>

Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian