netdev - Re: [PATCH net-next 11/12] wifi: wilc1000: Convert using devm_clk_get_optional_enabled() in wilc_sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5gqko2q.fsf@kernel.org>
Date: Mon, 02 Sep 2024 19:38:53 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Li Zetao <lizetao1@...wei.com>
Cc: <florian.fainelli@...adcom.com>,  <andrew@...n.ch>,
  <olteanv@...il.com>,  <davem@...emloft.net>,  <edumazet@...gle.com>,
  <kuba@...nel.org>,  <pabeni@...hat.com>,  <wens@...e.org>,
  <jernej.skrabec@...il.com>,  <samuel@...lland.org>,  <heiko@...ech.de>,
  <yisen.zhuang@...wei.com>,  <salil.mehta@...wei.com>,
  <hauke@...ke-m.de>,  <alexandre.torgue@...s.st.com>,
  <joabreu@...opsys.com>,  <mcoquelin.stm32@...il.com>,
  <wellslutw@...il.com>,  <radhey.shyam.pandey@....com>,
  <michal.simek@....com>,  <ajay.kathat@...rochip.com>,
  <claudiu.beznea@...on.dev>,  <u.kleine-koenig@...gutronix.de>,
  <jacky_chou@...eedtech.com>,  <netdev@...r.kernel.org>,
  <linux-arm-kernel@...ts.infradead.org>,  <linux-sunxi@...ts.linux.dev>,
  <linux-rockchip@...ts.infradead.org>,
  <linux-stm32@...md-mailman.stormreply.com>,
  <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH net-next 11/12] wifi: wilc1000: Convert using
 devm_clk_get_optional_enabled() in wilc_sdio_probe()

Li Zetao <lizetao1@...wei.com> writes:

> Use devm_clk_get_optional_enabled() instead of devm_clk_get_optional() +
> clk_prepare_enable(), which can make the clk consistent with the device
> life cycle and reduce the risk of unreleased clk resources. Since the
> device framework has automatically released the clk resource, there is
> no need to execute clk_disable_unprepare(clk) on the error path, drop
> the clk_disable_unprepare label, and the original error process can change
> to dispose_irq.
>
> Signed-off-by: Li Zetao <lizetao1@...wei.com>
> ---
>  drivers/net/wireless/microchip/wilc1000/sdio.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

wifi patches (patches 11 and 12) go via wireless-next, please submit
those separately.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html