netdev - Re: [PATCH -next 2/4] tun: Make use of str_disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240902091100.1fa07b84@kernel.org>
Date: Mon, 2 Sep 2024 09:11:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: Hongbo Li <lihongbo22@...wei.com>, kees@...nel.org, andy@...nel.org,
 willemdebruijn.kernel@...il.com, jasowang@...hat.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, akpm@...ux-foundation.org,
 linux-hardening@...r.kernel.org, netdev@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper

On Mon, 2 Sep 2024 09:10:33 +0300 Gal Pressman wrote:
> > You don't explain the 'why'. How is this an improvement?
> > nack on this and 2 similar networking changes you sent
> 
> Are you against the concept of string_choices in general, or this
> specific change?

Willem verbalized my opinion better than I can.

If a (driver|subsystem) maintainer likes string_choices that's
perfectly fine, but IMHO they are not worth converting to, and
not something we should suggest during review.