netdev - Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0341f08c-fe8b-4f9c-961e-9b773d67d7bf@huawei.com>
Date: Tue, 3 Sep 2024 20:13:58 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <shenjian15@...wei.com>,
	<wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<libaihan@...wei.com>, <andrew@...n.ch>, <jdamato@...tly.com>,
	<horms@...nel.org>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware
 configuration supported in this module


on 2024/9/3 19:59, Paolo Abeni wrote:
> On 8/30/24 14:15, Jijie Shao wrote:
> [...]
>> +static int hbg_mdio_wait_ready(struct hbg_mac *mac)
>> +{
>> +#define HBG_MDIO_OP_TIMEOUT_US        (1 * 1000 * 1000)
>> +#define HBG_MDIO_OP_INTERVAL_US        (5 * 1000)
>
> Minor nit: I find the define inside the function body less readable 
> than placing them just before the function itself.

These two macros are only used in this function.
Is it necessary to move them to the header file?

>
>> +
>> +    struct hbg_priv *priv = HBG_MAC_GET_PRIV(mac);
>> +    u32 cmd;
>> +
>> +    return readl_poll_timeout(priv->io_base + 
>> HBG_REG_MDIO_COMMAND_ADDR, cmd,
>> +                  !FIELD_GET(HBG_REG_MDIO_COMMAND_START_B, cmd),
>> +                  HBG_MDIO_OP_INTERVAL_US,
>> +                  HBG_MDIO_OP_TIMEOUT_US);
>> +}
>
> [...]> +static void hbg_phy_adjust_link(struct net_device *netdev)
>> +{
>> +    struct hbg_priv *priv = netdev_priv(netdev);
>> +    struct phy_device *phydev = priv->mac.phydev;
>
> Minor nit: please respect the reverse x-mas tree order

Here, I need to get the *priv first, so I'm not following the reverse x-mas tree order here.
I respect the reverse x-mas tree order everywhere else.

	Thanks,
	Jijie Shao