netdev - Re: [PATCH v1 6/7] wifi: wlcore: sdio: Make use of irq_get_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtchHGEBtn-BVB-l@smile.fi.intel.com>
Date: Tue, 3 Sep 2024 17:45:48 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: linux@...linux.org.uk, maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
	daniel@...ll.ch, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	andrew@...n.ch, f.fainelli@...il.com, olteanv@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, nico@...xnic.net, arend.vanspriel@...adcom.com,
	kvalo@...nel.org, robh@...nel.org, saravanak@...gle.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
	brcm80211-dev-list.pdl@...adcom.com, devicetree@...r.kernel.org
Subject: Re: [PATCH v1 6/7] wifi: wlcore: sdio: Make use of
 irq_get_trigger_type()

On Tue, Sep 03, 2024 at 12:55:33AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).

...

>  	memset(res, 0x00, sizeof(res));
>  
>  	res[0].start = irq;
> -	res[0].flags = IORESOURCE_IRQ |
> -		       irqd_get_trigger_type(irq_get_irq_data(irq));
> +	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
>  	res[0].name = "irq";


>  	if (wakeirq > 0) {
>  		res[1].start = wakeirq;
> -		res[1].flags = IORESOURCE_IRQ |
> -			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> +		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
>  		res[1].name = "wakeirq";
>  		num_irqs = 2;

Since you are touching a lot here, consider also using macros from ioport.h,
i.e. DEFINE_RES_IRQ_NAMED().

This will become something like

	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
	res[0].flags |= irq_get_trigger_type(irq);

	if (wakeirq > 0) {
		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
		res[1].flags |= irq_get_trigger_type(wakeirq);

-- 
With Best Regards,
Andy Shevchenko