netdev - Re: [PATCH net-next 0/4] Unmask upper DSCP bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1353cfd-565d-4f19-b21f-08beb997d3c3@kernel.org>
Date: Tue, 3 Sep 2024 08:45:33 -0600
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, gnault@...hat.com
Subject: Re: [PATCH net-next 0/4] Unmask upper DSCP bits - part 3

On 9/3/24 7:53 AM, Ido Schimmel wrote:
> tl;dr - This patchset continues to unmask the upper DSCP bits in the
> IPv4 flow key in preparation for allowing IPv4 FIB rules to match on
> DSCP. No functional changes are expected.
> 
> The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB
> lookup to match against the TOS selector in FIB rules and routes.
> 
> It is currently impossible for user space to configure FIB rules that
> match on the DSCP value as the upper DSCP bits are either masked in the
> various call sites that initialize the IPv4 flow key or along the path
> to the FIB core.
> 
> In preparation for adding a DSCP selector to IPv4 and IPv6 FIB rules, we
> need to make sure the entire DSCP value is present in the IPv4 flow key.
> This patchset continues to unmask the upper DSCP bits, but this time in
> the output route path, specifically in the callers of
> ip_route_output_ports().
> 
> The next patchset (last) will handle the callers of
> ip_route_output_key(). Split from this patchset to avoid going over the
> 15 patches limit.
> 
> No functional changes are expected as commit 1fa3314c14c6 ("ipv4:
> Centralize TOS matching") moved the masking of the upper DSCP bits to
> the core where 'flowi4_tos' is matched against the TOS selector.
> 
> Ido Schimmel (4):
>   ipv4: Unmask upper DSCP bits in __ip_queue_xmit()
>   ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit()
>   ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err()
>   ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev()
> 
>  net/ipv4/ip_output.c  | 2 +-
>  net/ipv4/ipmr.c       | 4 ++--
>  net/ipv6/ip6_tunnel.c | 7 +++++--
>  net/ipv6/sit.c        | 2 +-
>  4 files changed, 9 insertions(+), 6 deletions(-)
> 

For the set:

Reviewed-by: David Ahern <dsahern@...nel.org>