netdev - Re: [PATCH net-next 1/4] ipv4: Unmask upper DSCP bits in __ip_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ztcwz14WPh4Q9hpZ@debian>
Date: Tue, 3 Sep 2024 17:52:47 +0200
From: Guillaume Nault <gnault@...hat.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com, dsahern@...nel.org
Subject: Re: [PATCH net-next 1/4] ipv4: Unmask upper DSCP bits in
 __ip_queue_xmit()

On Tue, Sep 03, 2024 at 04:53:24PM +0300, Ido Schimmel wrote:
> The function is passed the full DS field in its 'tos' argument by its
> two callers. It then masks the upper DSCP bits using RT_TOS() when
> passing it to ip_route_output_ports().
> 
> Unmask the upper DSCP bits when passing 'tos' to ip_route_output_ports()
> so that in the future it could perform the FIB lookup according to the
> full DSCP value.

Reviewed-by: Guillaume Nault <gnault@...hat.com>