netdev - Re: [PATCH net-next v2] l2tp: remove unneeded null check in l2tp_v2_session_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240903163549.GF4792@kernel.org>
Date: Tue, 3 Sep 2024 17:35:49 +0100
From: Simon Horman <horms@...nel.org>
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org,
	kernel test robot <lkp@...el.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Tom Parkin <tparkin@...alix.com>
Subject: Re: [PATCH net-next v2] l2tp: remove unneeded null check in
 l2tp_v2_session_get_next

On Tue, Sep 03, 2024 at 12:35:47PM +0100, James Chapman wrote:
> Commit aa92c1cec92b ("l2tp: add tunnel/session get_next helpers") uses
> idr_get_next APIs to iterate over l2tp session IDR lists.  Sessions in
> l2tp_v2_session_idr always have a non-null session->tunnel pointer
> since l2tp_session_register sets it before inserting the session into
> the IDR. Therefore the null check on session->tunnel in
> l2tp_v2_session_get_next is redundant and can be removed. Removing the
> check avoids a warning from lkp.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/r/202408111407.HtON8jqa-lkp@intel.com/
> CC: Dan Carpenter <dan.carpenter@...aro.org>
> Signed-off-by: James Chapman <jchapman@...alix.com>
> Acked-by: Tom Parkin <tparkin@...alix.com>
> ---
> 
>  v2: improve commit log and use acked-by tag
>  v1: https://lore.kernel.org/netdev/20240902142953.926891-1-jchapman@katalix.com/
> 

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>