netdev - Re: [PATCH -next] ionic: Remove redundant null pointer checks in ionic_debugfs_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36f30b18-36e2-4e7c-a801-47fac932b1ed@amd.com>
Date: Tue, 3 Sep 2024 09:36:22 -0700
From: Brett Creeley <bcreeley@....com>
To: Li Zetao <lizetao1@...wei.com>, shannon.nelson@....com,
 brett.creeley@....com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, kalesh-anakkur.purayil@...adcom.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH -next] ionic: Remove redundant null pointer checks in
 ionic_debugfs_add_qcq()



On 9/3/2024 7:31 AM, Li Zetao wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Since the debugfs_create_dir() never returns a null pointer, checking
> the return value for a null pointer is redundant, and using IS_ERR is
> safe enough.
> 
> Signed-off-by: Li Zetao <lizetao1@...wei.com>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> index 59e5a9f21105..c98b4e75e288 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> @@ -123,7 +123,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq)
>          struct ionic_cq *cq = &qcq->cq;
> 
>          qcq_dentry = debugfs_create_dir(q->name, lif->dentry);
> -       if (IS_ERR_OR_NULL(qcq_dentry))
> +       if (IS_ERR(qcq_dentry))
>                  return;

For the patch contents this LGTM.

However, the patch subject prefix should be "[PATCH net-next]" for the 
first version. Specifically, replace "-next" with "net-next".

Thanks,

Brett

>          qcq->dentry = qcq_dentry;
> 
> --
> 2.34.1
>