netdev - Re: [PATCH net] selftests: rtnetlink: add 'ethtool' as a dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtdxW9v8oWt-Ows8@mini-arch>
Date: Tue, 3 Sep 2024 13:28:11 -0700
From: Stanislav Fomichev <sdf@...ichev.me>
To: Ales Nezbeda <anezbeda@...hat.com>
Cc: netdev@...r.kernel.org, sd@...asysnail.net, davem@...emloft.net
Subject: Re: [PATCH net] selftests: rtnetlink: add 'ethtool' as a dependency

On 09/03, Ales Nezbeda wrote:
> Introduction of `kci_test_macsec_offload()` in `rtnetlink.sh` created
> a new dependency `ethtool` for the test suite. This dependency is not
> reflected in checks that run before all the tests, so if the `ethtool`
> is not present, all tests will start, but `macsec_offload` test will
> fail with a misleading message. Message would say that MACsec offload is
> not supported, yet it never actually managed to check this, since it
> needs the `ethtool` to do so.
> 
> Fixes: 3b5222e2ac57 ("selftests: rtnetlink: add MACsec offload tests")
> Signed-off-by: Ales Nezbeda <anezbeda@...hat.com>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index bdf6f10d0558..fdd116458222 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -1306,6 +1306,7 @@ if [ "$(id -u)" -ne 0 ];then
>  	exit $ksft_skip
>  fi
>  
> +#check for dependencies
>  for x in ip tc;do
>  	$x -Version 2>/dev/null >/dev/null
>  	if [ $? -ne 0 ];then
> @@ -1313,6 +1314,11 @@ for x in ip tc;do
>  		exit $ksft_skip
>  	fi
>  done
> +ethtool --version 2>/dev/null >/dev/null
> +if [ $? -ne 0 ];then
> +	end_test "SKIP: Could not run test without the ethtool tool"
> +	exit $ksft_skip
> +fi

Can we use a 'require_command ethtool' (lib.sh helper) instead?