netdev - Re: [PATCH net] selftests: rtnetlink: add 'ethtool' as a dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_-bo0tuXSpE_kMbYUWCktfSXxMP8vx1eYq=0_RspFsbx68AA@mail.gmail.com>
Date: Mon, 9 Sep 2024 01:09:55 +0200
From: Ales Nezbeda <anezbeda@...hat.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, sd@...asysnail.net, davem@...emloft.net
Subject: Re: [PATCH net] selftests: rtnetlink: add 'ethtool' as a dependency

On Tue, Sep 3, 2024 at 10:28 PM Stanislav Fomichev <sdf@...ichev.me> wrote:
> Can we use a 'require_command ethtool' (lib.sh helper) instead?

Hi, I apologize for not responding so long, I have looked at the
function from the `lib.sh` helper you mentioned. Thanks for pointing
it out, it is a much cleaner solution and would resolve the need to
test 'ip' and 'tc' differently from the 'ethtool'. It seems that it is
currently not present in the `lib.sh` file that is used in the
`rtnetlink.sh` that is modified by the patch.

There are multiple versions of `lib.sh` file, and the
`require_command` function is defined in only two of them. It looks
like some of the tests are reusing the `lib.sh` file that does contain
the `require_command` function from other tests (like
`selftests/drivers/net/netdevsim/psample.sh`), but I feel like adding
the `require_command` function to the currently used `lib.sh` file is
a cleaner solution.

I will create a new patch that will add the `require_command` to
`lib.sh` file and rewrite the check in `rtnetlink.sh` to use that
function.