[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240904110440.GS4792@kernel.org>
Date: Wed, 4 Sep 2024 12:04:40 +0100
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, thepacketgeek@...il.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, davej@...emonkey.org.uk,
thevlad@...a.com, max@...sevol.com
Subject: Re: [PATCH net-next 5/9] net: netconsole: introduce variable to
track body length
On Tue, Sep 03, 2024 at 07:07:48AM -0700, Breno Leitao wrote:
> This new variable tracks the total length of the data to be sent,
> encompassing both the message body (msgbody) and userdata, which is
> collectively called body.
>
> By explicitly defining body_len, the code becomes clearer and easier to
> reason about, simplifying offset calculations and improving overall
> readability of the function.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
Thanks,
I agree that this improves the clarify of the code.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists