netdev - Re: [PATCH net-next 09/12] net: ethernet: sunplus: Convert using devm_clk_get_enabled() in spl2sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65a6fdd6-5afc-47b6-ab24-3ba05007eb48@lunn.ch>
Date: Wed, 4 Sep 2024 07:20:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Li Zetao <lizetao1@...wei.com>
Cc: Jakub Kicinski <kuba@...nel.org>, florian.fainelli@...adcom.com,
	olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, wens@...e.org, jernej.skrabec@...il.com,
	samuel@...lland.org, heiko@...ech.de, yisen.zhuang@...wei.com,
	salil.mehta@...wei.com, hauke@...ke-m.de,
	alexandre.torgue@...s.st.com, joabreu@...opsys.com,
	mcoquelin.stm32@...il.com, wellslutw@...il.com,
	radhey.shyam.pandey@....com, michal.simek@....com,
	ajay.kathat@...rochip.com, claudiu.beznea@...on.dev,
	kvalo@...nel.org, u.kleine-koenig@...gutronix.de,
	jacky_chou@...eedtech.com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
	linux-rockchip@...ts.infradead.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next 09/12] net: ethernet: sunplus: Convert using
 devm_clk_get_enabled() in spl2sw_probe()

On Wed, Sep 04, 2024 at 09:27:06AM +0800, Li Zetao wrote:
> Hi,
> 
> 在 2024/9/4 6:16, Jakub Kicinski 写道:
> > On Sat, 31 Aug 2024 10:13:31 +0800 Li Zetao wrote:
> > > +	comm->clk = devm_clk_get_enabled(&pdev->dev, NULL);
> > 
> > You can remove clk from the driver struct now.
> I don’t quite understand why clk can be removed from the driver struct,

After you patch, where is it used?

	Andrew