netdev - Re: [PATCH net-next v3 0/4] Add option to provide OPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66d8cb426bc39_163d93294e@willemb.c.googlers.com.notmuch>
Date: Wed, 04 Sep 2024 17:04:02 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
 Willem de Bruijn <willemb@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 David Ahern <dsahern@...nel.org>, 
 Jason Xing <kerneljasonxing@...il.com>, 
 Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/4] Add option to provide OPT_ID value via
 cmsg

> > 
> > Vadim Fedorenko (4):
> >    net_tstamp: add SCM_TS_OPT_ID to provide OPT_ID in control message
> >    net_tstamp: add SCM_TS_OPT_ID for TCP sockets
> >    net_tstamp: add SCM_TS_OPT_ID for RAW sockets
> >    selftests: txtimestamp: add SCM_TS_OPT_ID test
> > 
> Oh, sorry for the mess, patches:
> 
> [PATCH v3 2/3] selftests: txtimestamp: add SCM_TS_OPT_ID test
> [PATCH v3 3/3] net_tstamp: add SCM_TS_OPT_ID for TCP sockets
> 
> should be ignored.
> 
> If it too messy I can resend the series.

The series looks good to me. The four patches listed in the cover
letter summary.

Overall looks great.

Perhaps the test can now also test TCP and RAW with a fixed OPT_ID.