netdev - Re: [PATCH net-next v3 0/4] Add option to provide OPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b0e208a-a986-46a2-bd58-6464ae8da7d4@linux.dev>
Date: Wed, 4 Sep 2024 23:50:37 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Willem de Bruijn <willemb@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
 Jason Xing <kerneljasonxing@...il.com>, Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/4] Add option to provide OPT_ID value via
 cmsg

On 04/09/2024 22:04, Willem de Bruijn wrote:
>>>
>>> Vadim Fedorenko (4):
>>>     net_tstamp: add SCM_TS_OPT_ID to provide OPT_ID in control message
>>>     net_tstamp: add SCM_TS_OPT_ID for TCP sockets
>>>     net_tstamp: add SCM_TS_OPT_ID for RAW sockets
>>>     selftests: txtimestamp: add SCM_TS_OPT_ID test
>>>
>> Oh, sorry for the mess, patches:
>>
>> [PATCH v3 2/3] selftests: txtimestamp: add SCM_TS_OPT_ID test
>> [PATCH v3 3/3] net_tstamp: add SCM_TS_OPT_ID for TCP sockets
>>
>> should be ignored.
>>
>> If it too messy I can resend the series.
> 
> The series looks good to me. The four patches listed in the cover
> letter summary.
> 
> Overall looks great.
> 
> Perhaps the test can now also test TCP and RAW with a fixed OPT_ID.

Sure, I'll add these tests. As well as changes to address comments for 
1/4 patch.

Thanks,
Vadim