netdev - Re: [PATCH net-next 05/16] net: macb: Remove setting of RX software timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43c561ff-f7a0-4313-aaac-62a2c3992eb6@microchip.com>
Date: Mon, 9 Sep 2024 09:00:22 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Gal Pressman <gal@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, Jay Vosburgh <jv@...sburgh.net>, Andy Gospodarek
	<andy@...yhouse.net>, Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol
	<mailhol.vincent@...adoo.fr>, Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Sudarsana Kalluru <skalluru@...vell.com>, Manish Chopra
	<manishc@...vell.com>, Michael Chan <michael.chan@...adcom.com>, Pavan Chebbi
	<pavan.chebbi@...adcom.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	"Sunil Goutham" <sgoutham@...vell.com>, Potnuri Bharat Teja
	<bharat@...lsio.com>, Christian Benvenuti <benve@...co.com>, Satish Kharat
	<satishkh@...co.com>, Claudiu Manoil <claudiu.manoil@....com>, Vladimir
 Oltean <vladimir.oltean@....com>, Wei Fang <wei.fang@....com>, Shenwei Wang
	<shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, "Dimitris
 Michailidis" <dmichail@...gible.com>, Yisen Zhuang <yisen.zhuang@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>, Jijie Shao <shaojijie@...wei.com>,
	"Tony Nguyen" <anthony.l.nguyen@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, Marcin Wojtas <marcin.s.wojtas@...il.com>,
	Russell King <linux@...linux.org.uk>, Geetha sowjanya <gakula@...vell.com>,
	Subbaraya Sundeep <sbhatta@...vell.com>, hariprasad <hkelam@...vell.com>,
	"Ido Schimmel" <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, "Bryan
 Whitehead" <bryan.whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>, Lars Povlsen
	<lars.povlsen@...rochip.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>,
	Daniel Machon <daniel.machon@...rochip.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Shannon Nelson <shannon.nelson@....com>,
	Brett Creeley <brett.creeley@....com>, Sergey Shtylyov <s.shtylyov@....ru>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Niklas Söderlund <niklas.soderlund@...natech.se>, "Edward
 Cree" <ecree.xilinx@...il.com>, Martin Habets <habetsm.xilinx@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
	<joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Siddharth Vadapalli <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>,
	MD Danish Anwar <danishanwar@...com>, Linus Walleij <linusw@...nel.org>,
	"Imre Kaloz" <kaloz@...nwrt.org>, Richard Cochran <richardcochran@...il.com>,
	"Willem de Bruijn" <willemdebruijn.kernel@...il.com>, Carolina Jubran
	<cjubran@...dia.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [PATCH net-next 05/16] net: macb: Remove setting of RX software
 timestamp

On 06/09/2024 at 16:46, Gal Pressman wrote:
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
> 
> Reviewed-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Signed-off-by: Gal Pressman <gal@...dia.com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks, best regards,
   Nicolas

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 95e8742dce1d..e41929c61a04 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3410,8 +3410,6 @@ static int gem_get_ts_info(struct net_device *dev,
> 
>          info->so_timestamping =
>                  SOF_TIMESTAMPING_TX_SOFTWARE |
> -               SOF_TIMESTAMPING_RX_SOFTWARE |
> -               SOF_TIMESTAMPING_SOFTWARE |
>                  SOF_TIMESTAMPING_TX_HARDWARE |
>                  SOF_TIMESTAMPING_RX_HARDWARE |
>                  SOF_TIMESTAMPING_RAW_HARDWARE;
> @@ -3423,7 +3421,8 @@ static int gem_get_ts_info(struct net_device *dev,
>                  (1 << HWTSTAMP_FILTER_NONE) |
>                  (1 << HWTSTAMP_FILTER_ALL);
> 
> -       info->phc_index = bp->ptp_clock ? ptp_clock_index(bp->ptp_clock) : -1;
> +       if (bp->ptp_clock)
> +               info->phc_index = ptp_clock_index(bp->ptp_clock);
> 
>          return 0;
>   }
> --
> 2.40.1
>