netdev - Re: [PATCH net-next 14/16] net: stmmac: Remove setting of RX software timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240909174804.6be54abd@kernel.org>
Date: Mon, 9 Sep 2024 17:48:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>, Jay
 Vosburgh <jv@...sburgh.net>, Andy Gospodarek <andy@...yhouse.net>, Marc
 Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol
 <mailhol.vincent@...adoo.fr>, Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Sudarsana Kalluru <skalluru@...vell.com>, Manish Chopra
 <manishc@...vell.com>, Michael Chan <michael.chan@...adcom.com>, Pavan
 Chebbi <pavan.chebbi@...adcom.com>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Sunil Goutham <sgoutham@...vell.com>, Potnuri Bharat Teja
 <bharat@...lsio.com>, "Christian Benvenuti" <benve@...co.com>, Satish
 Kharat <satishkh@...co.com>, "Claudiu Manoil" <claudiu.manoil@....com>,
 Vladimir Oltean <vladimir.oltean@....com>, Wei Fang <wei.fang@....com>,
 Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
 Dimitris Michailidis <dmichail@...gible.com>, "Yisen Zhuang"
 <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>, "Jijie
 Shao" <shaojijie@...wei.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>, Marcin Wojtas
 <marcin.s.wojtas@...il.com>, Russell King <linux@...linux.org.uk>, "Geetha
 sowjanya" <gakula@...vell.com>, Subbaraya Sundeep <sbhatta@...vell.com>,
 hariprasad <hkelam@...vell.com>, Ido Schimmel <idosch@...dia.com>, "Petr
 Machata" <petrm@...dia.com>, Bryan Whitehead
 <bryan.whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>, Horatiu
 Vultur <horatiu.vultur@...rochip.com>, Lars Povlsen
 <lars.povlsen@...rochip.com>, Steen Hegelund
 <Steen.Hegelund@...rochip.com>, Daniel Machon
 <daniel.machon@...rochip.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Shannon Nelson <shannon.nelson@....com>,
 Brett Creeley <brett.creeley@....com>, Sergey Shtylyov <s.shtylyov@....ru>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Niklas
 Söderlund <niklas.soderlund@...natech.se>, "Edward Cree"
 <ecree.xilinx@...il.com>, Martin Habets <habetsm.xilinx@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
 <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Siddharth Vadapalli <s-vadapalli@...com>, Roger Quadros
 <rogerq@...nel.org>, MD Danish Anwar <danishanwar@...com>, Linus Walleij
 <linusw@...nel.org>, "Imre Kaloz" <kaloz@...nwrt.org>, Richard Cochran
 <richardcochran@...il.com>, "Willem de Bruijn"
 <willemdebruijn.kernel@...il.com>, Carolina Jubran <cjubran@...dia.com>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [PATCH net-next 14/16] net: stmmac: Remove setting of RX
 software timestamp

On Fri, 6 Sep 2024 17:46:30 +0300 Gal Pressman wrote:
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
> 
> Reviewed-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Signed-off-by: Gal Pressman <gal@...dia.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index 7008219fd88d..a7b8407e898c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -1207,13 +1207,13 @@ static int stmmac_get_ts_info(struct net_device *dev,
>  
>  		info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
>  					SOF_TIMESTAMPING_TX_HARDWARE |
> -					SOF_TIMESTAMPING_RX_SOFTWARE |
>  					SOF_TIMESTAMPING_RX_HARDWARE |
> -					SOF_TIMESTAMPING_SOFTWARE |
>  					SOF_TIMESTAMPING_RAW_HARDWARE;
>  
>  		if (priv->ptp_clock)
>  			info->phc_index = ptp_clock_index(priv->ptp_clock);
> +		else
> +			info->phc_index = 0;

Would have been good to explain the unusual change to phc_index
in the commit message.