netdev - Re: [PATCH net-next 3/3] bnxt_en: resize bnxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240910083423.GF525413@kernel.org>
Date: Tue, 10 Sep 2024 09:34:23 +0100
From: Simon Horman <horms@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, gospo@...adcom.com,
	selvin.xavier@...adcom.com, pavan.chebbi@...adcom.com
Subject: Re: [PATCH net-next 3/3] bnxt_en: resize bnxt_irq name field to fit
 format string

On Mon, Sep 09, 2024 at 01:27:37PM -0700, Michael Chan wrote:
> From: Edwin Peer <edwin.peer@...adcom.com>
> 
> The name field of struct bnxt_irq is written using snprintf in
> bnxt_setup_msix(). Make the field large enough to fit the maximal
> formatted string to prevent truncation.  Truncated IRQ names are
> less meaningful to the user.  For example, "enp4s0f0np0-TxRx-0"
> gets truncated to "enp4s0f0np0-TxRx-" with the existing code.
> 
> Make sure we have space for the extra characters added to the IRQ
> names:
> 
>   - the characters introduced by the static format string: hyphens
>   - the maximal static substituted ring type string: "TxRx"
>   - the maximum length of an integer formatted as a string, even
>     though reasonable ring numbers would never be as long as this.
> 
> Signed-off-by: Edwin Peer <edwin.peer@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Reviewed-by: Simon Horman <horms@...nel.org>