[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <67481e1d-e0bd-4629-bbe9-4fe03fb1920d@lunn.ch>
Date: Tue, 10 Sep 2024 14:01:07 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Tarun Alle <tarun.alle@...rochip.com>
Cc: arun.ramadoss@...rochip.com, UNGLinuxDriver@...rochip.com,
hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next V2] net: phy: microchip_t1: SQI support for
LAN887x
> + /* Keep inliers and discard outliers */
> + for (int i = 40; i < 160; i++)
> + sqiavg += rawtable[i];
for (int i = ARRAY_SIZE(rawtable) / 5 ; i < ARRAY_SIZE(rawtable) / 5 * 4; i++) {
You don't want to hard code the size of the array anywhere except for
when actually declaring it. It then becomes easy to change the size of
it.
Andrew
Powered by blists - more mailing lists