[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<DM4PR11MB6239909262BA13511B49873C8B9B2@DM4PR11MB6239.namprd11.prod.outlook.com>
Date: Wed, 11 Sep 2024 06:59:35 +0000
From: <Tarun.Alle@...rochip.com>
To: <andrew@...n.ch>
CC: <Arun.Ramadoss@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
<hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next V2] net: phy: microchip_t1: SQI support for
LAN887x
Hi Andrew,
Thanks for the review comment.
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Tuesday, September 10, 2024 5:31 PM
> To: Tarun Alle - I68638 <Tarun.Alle@...rochip.com>
> Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@...rochip.com>;
> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>; hkallweit1@...il.com;
> linux@...linux.org.uk; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH net-next V2] net: phy: microchip_t1: SQI support for
> LAN887x
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> > + /* Keep inliers and discard outliers */
> > + for (int i = 40; i < 160; i++)
> > + sqiavg += rawtable[i];
>
> for (int i = ARRAY_SIZE(rawtable) / 5 ; i < ARRAY_SIZE(rawtable) / 5 * 4;
> i++) {
>
> You don't want to hard code the size of the array anywhere except for when
> actually declaring it. It then becomes easy to change the size of it.
>
Will fix in next version.
> Andrew
Thanks,
Tarun Alle.
Powered by blists - more mailing lists